Change bitfields from enum to uint64 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements spec change open-telemetry/opamp-spec#125 In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly. This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.
Codecov ReportBase: 74.33% // Head: 74.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 74.33% 74.84% +0.50%
==========================================
Files 23 23
Lines 1765 1765
==========================================
+ Hits 1312 1321 +9
+ Misses 339 331 -8
+ Partials 114 113 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@andykellr can you please review so that we can merge this? We want to move the protos and I want to make sure we don't have outstanding proto changes in this repo. |
andykellr
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements spec change open-telemetry/opamp-spec#125
In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly.
This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.